[Typing] support Numeric with bool in type hints #74145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
fix unstack type hints and improve CastNumpy2Scalar's error message
ooooo-create force-pushed the refine_type_hints branch from f916cda to bfec8c6 Compare 
SigureMo changed the title 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## develop #74145 +/- ## =========================================== Coverage ? 100.00% =========================================== Files ? 2 Lines ? 2 Branches ? 0 =========================================== Hits ? 2 Misses ? 0 Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
torch 中 Number 相关注解都会加上 bool，numpy 和 jax 中是 Scalar，也包含了 bool
主要是 refine full and full_like for fill_value type check and annotations #74127 要用到了