Skip to content

Conversation

@Difers
Copy link
Contributor

@Difers Difers commented Jul 21, 2025

PR Category

Auto Parallel

PR Types

Bug fixes

Description

Pcard-73145
修改group_norm及layernorm 切分推导bug

  • group_norm中mean,variance,shape应该是二维[N, G],原实现是一维,需修改
  • layernorm中bias可能为None,需添加check
@paddle-bot
Copy link

paddle-bot bot commented Jul 21, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@Difers Difers force-pushed the fix_some_norm_spmd branch from ddd50be to 1a5e250 Compare July 21, 2025 12:21
bias_ndim));
PADDLE_ENFORCE_EQ(
mean_ndim,
1,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是直接去掉,还是应该改成2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改~

@Difers Difers force-pushed the fix_some_norm_spmd branch from 1a5e250 to 90e6378 Compare July 22, 2025 08:34
@Difers Difers force-pushed the fix_some_norm_spmd branch from 90e6378 to f9ed4e3 Compare July 22, 2025 09:30
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhiqiu zhiqiu merged commit 35fcca3 into PaddlePaddle:develop Jul 23, 2025
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants