Skip to content

Conversation

@cangtianhuang
Copy link
Contributor

@cangtianhuang cangtianhuang commented Jul 19, 2025

PR Category

Operator Mechanism

PR Types

Improvements

Description

Support complex64 , complex128 for paddle.linalg.lu_unpack , paddle.linalg.lu_solve op.

Add @unittest.skipIf for paddle.linalg.lu_solve op test because its grad_impl doesn't support complex calculation in Linux-DCU.

Pcard-85711

@paddle-bot
Copy link

paddle-bot bot commented Jul 19, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@8341678). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/kernels/funcs/lapack/lapack_function.cc 0.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (57.14%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@ Coverage Diff @@ ## develop #74130 +/- ## ========================================== Coverage ? 57.14% ========================================== Files ? 5 Lines ? 14 Branches ? 0 ========================================== Hits ? 8 Misses ? 6 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 再请书豪看看

@cangtianhuang
Copy link
Contributor Author

/re-run all-failed

@wanghuancoder wanghuancoder merged commit d9fa2fd into PaddlePaddle:develop Jul 22, 2025
80 of 86 checks passed
@cangtianhuang cangtianhuang deleted the fix-lu-solve branch July 26, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

5 participants