Skip to content

[0-size Tensor No.166、257] Add 0-size Tensor support for paddle.nn.functional.ctc_loss [fluid_ops] #74042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 18, 2025
Merged

[0-size Tensor No.166、257] Add 0-size Tensor support for paddle.nn.functional.ctc_loss [fluid_ops] #74042

merged 9 commits into from
Jul 18, 2025

Conversation

@co63oc
Copy link
Contributor

@co63oc co63oc commented Jul 15, 2025 •
edited
Loading

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

166 paddle.nn.functional.ctc_loss
PaddleAPITest 测试为numpy error, torch error
image

类似 margin_cross_entropy PFCCLab/PaddleAPITest#354 改为抛出错误，python部分修改有性能问题，在infermeta和符号推导修改
image

257 paddle.signal.istft 测试用例都不支持0-size，修改为抛出错误
@paddle-bot
Copy link

paddle-bot bot commented Jul 15, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@paddle-bot paddle-bot bot added the contributor External developers label Jul 15, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@ce7f373). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...terface/infer_symbolic_shape/multiary_infer_sym.cc 80.00% 1 Missing ⚠️
paddle/phi/infermeta/multiary.cc 50.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (75.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@ Coverage Diff @@ ## develop #74042 +/- ## ========================================== Coverage ? 75.00% ========================================== Files ? 3 Lines ? 8 Branches ? 0 ========================================== Hits ? 6 Misses ? 2 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@DanielSun11 DanielSun11 self-assigned this Jul 15, 2025
@co63oc co63oc changed the title [0-size Tensor No.166] Add 0-size Tensor support for paddle.nn.functional.ctc_loss [0-size Tensor No.166] Add 0-size Tensor support for paddle.nn.functional.ctc_loss [fluid_ops] Jul 16, 2025
@luotao1 luotao1 added the HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务 label Jul 16, 2025
@luotao1 luotao1 self-assigned this Jul 16, 2025
@luotao1 luotao1 mentioned this pull request Jul 16, 2025
Closed
@co63oc co63oc changed the title [0-size Tensor No.166] Add 0-size Tensor support for paddle.nn.functional.ctc_loss [fluid_ops] [0-size Tensor No.166、257] Add 0-size Tensor support for paddle.nn.functional.ctc_loss [fluid_ops] Jul 16, 2025
@co63oc
Copy link
Contributor Author

co63oc commented Jul 17, 2025

/re-run all-failed
@DanielSun11
Copy link
Contributor

DanielSun11 commented Jul 17, 2025 •
edited
Loading

修改为抛出错误之后，之前的测试用例应该是报[paddle error],请在paddleapitest中将这些测试用例删掉，避免复测继续报错。PFCCLab/PaddleAPITest#354 close了，删除配置好像并未生效
@co63oc
Copy link
Contributor Author

co63oc commented Jul 17, 2025

修改为抛出错误之后，之前的测试用例应该是报[paddle error],请在paddleapitest中将这些测试用例删掉，避免复测继续报错。PFCCLab/PaddleAPITest#354 close了，删除配置好像并未生效

已打开PR，增加了当前PR中算子，待确认后配置会删除
DanielSun11
DanielSun11 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@DanielSun11 DanielSun11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@DanielSun11
Copy link
Contributor

涉及符号推导的修改，请 @luotao1 协调云飞review下
@co63oc co63oc mentioned this pull request Jul 18, 2025
Merged
@luotao1 luotao1 merged commit 6460d1d into PaddlePaddle:develop Jul 18, 2025
69 of 71 checks passed
co63oc added a commit to co63oc/Paddle that referenced this pull request Jul 18, 2025
@co63oc
[0-size Tensor No.166、257] Add 0-size Tensor support for paddle.nn.fu…
6d901de 
…nctional.ctc_loss [fluid_ops] (PaddlePaddle#74042) * Fix * Fix * Fix * ci * Fix * Fix * Fix
@co63oc co63oc deleted the h19 branch July 18, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动，更具挑战性的任务

5 participants

@co63oc @codecov-commenter @DanielSun11 @zyfncg @luotao1