Skip to content

Conversation

@huangjiyi
Copy link
Member

@huangjiyi huangjiyi commented Jul 11, 2025

PR Category

Operator Mechanism

PR Types

Bug fixes

Description

  • 修复 max_pool_with_index 和 fractional_max_pool 底层几个 Kernel 的 int 溢出问题
  • 由于部分 Kernel int64 版本性能有下降,均以模版实现
  • kernel_size, strides, paddings 参数未在 API 层改成 int64,只是在 Kernel Launch 时进行了 cast,待后续提 PR 修改

Pcard-91573

@paddle-bot
Copy link

paddle-bot bot commented Jul 11, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2025

Codecov Report

Attention: Patch coverage is 32.96703% with 122 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@e35cc9b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/kernels/funcs/pooling.cc 32.96% 122 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #73993 +/- ## ========================================== Coverage ? 32.96% ========================================== Files ? 1 Lines ? 182 Branches ? 0 ========================================== Hits ? 60 Misses ? 122 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@huangjiyi huangjiyi changed the title [PHI] Fix int32 overflow for max_pool_with_index [PHI] Fix int32 overflow for max_pool_with_index and fractional_max_pool Jul 14, 2025
Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huangjiyi huangjiyi merged commit 3b30714 into PaddlePaddle:develop Jul 14, 2025
70 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment