[Phi] Fix einsum kernel for big tensor #73899
Merged
+65 −62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
| /re-run all-failed |
lshpku reviewed Jul 9, 2025
Comment on lines +75 to 76
| // map a label('a' - 'z') -> int64_t, O(1) speed. | ||
| class LabelMap { |
There was a problem hiding this comment.
这个LabelMap也要用int64吗？看起来只是map到了一个axis，不是map到shape
There was a problem hiding this comment.
key是axis，用label'a-z'来表示，在数组索引的时候将label修饰为int；value是shape，所以也要改成int64.
lshpku approved these changes Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
将einsum的前向和反向kernel与shape有关的参数类型改为int64_t，支持大Tensor运算。
float16的精度问题仍然存在，预测与matmul kernel相关。