Polish GetPlacesOp #7381
Merged
Polish GetPlacesOp #7381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
reyoung force-pushed the feature/refine_get_places_op branch from 0fd0949 to 4059c9c Compare 
reyoung commented Jan 10, 2018
| def get_places(device_count=None, device_type=None): | ||
| helper = LayerHelper('get_places', **locals()) | ||
| out_places = helper.create_variable(name=unique_name(helper.name + ".out")) | ||
| attrs = dict() |
There was a problem hiding this comment.
Do not set device_count and device_type if the user does not specify them.
Because C++ side will set the default value. Do not set default value twice, it makes code harder to maintain.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #7382