Skip to content

Add Fp8 moe fusion ops #73763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 8, 2025
Merged

Add Fp8 moe fusion ops #73763

merged 7 commits into from
Jul 8, 2025

Conversation

@zhangyuqin1998
Copy link
Contributor

@zhangyuqin1998 zhangyuqin1998 commented Jul 2, 2025 •
edited
Loading

PR Category

Operator Mechanism

PR Types

New features

Description

新增FP8量化+moe_dispatch融合算子：moe_gate_dispatch_and_quant
封装了一下重复使用的代码

Pcard-91067
@paddle-bot
Copy link

paddle-bot bot commented Jul 2, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.51852% with 44 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@1782c9a). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddle/phi/infermeta/ternary.cc 0.00% 35 Missing ⚠️
...ubate/nn/functional/moe_gate_dispatch_and_quant.py 50.00% 9 Missing ⚠️

❌ Your patch status has failed because the patch coverage (18.51%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@ Coverage Diff @@ ## develop #73763 +/- ## ========================================== Coverage ? 18.51% ========================================== Files ? 3 Lines ? 54 Branches ? 0 ========================================== Hits ? 10 Misses ? 44 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
2 similar comments
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
ForFishes
ForFishes previously approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
zrr1999
zrr1999 requested changes Jul 3, 2025
View reviewed changes
zrr1999
zrr1999 reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@zrr1999 zrr1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typehint 没什么其他问题了
@zhangyuqin1998 zhangyuqin1998 mentioned this pull request Jul 4, 2025
Merged
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
zrr1999
zrr1999 previously approved these changes Jul 4, 2025
View reviewed changes
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
1 similar comment
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998 zhangyuqin1998 mentioned this pull request Jul 4, 2025
Merged
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
2 similar comments
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
1 similar comment
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
1 similar comment
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
XiaoguangHu01
XiaoguangHu01 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
@zhangyuqin1998
Copy link
Contributor Author

/re-run all-failed
ForFishes
ForFishes approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@ForFishes ForFishes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ForFishes ForFishes merged commit 57d1e08 into PaddlePaddle:develop Jul 8, 2025
178 of 197 checks passed
@zhangyuqin1998 zhangyuqin1998 changed the title Aff Fp8 moe fusion ops Add Fp8 moe fusion ops Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci: coverage

8 participants

@zhangyuqin1998 @codecov-commenter @zyfncg @ForFishes @tianshuo78520a @zrr1999 @XiaoguangHu01 @XieYunshen