-
Couldn't load subscription status.
- Fork 5.9k
[AutoParallel] Add einsum spmd rules #73753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 你的PR提交成功,感谢你对开源项目的贡献! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #73753 +/- ## ========================================== Coverage ? 99.05% ========================================== Files ? 1 Lines ? 211 Branches ? 0 ========================================== Hits ? 209 Misses ? 2 Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /re-run all-failed |
| std::string* output) { | ||
| // For fwd spmd rule, only those diagonal labels in output should not be | ||
| // sharded. But for bwd spmd rule, input and output are switched. So we simply | ||
| // set the spmd rule here to replace all diagonal labels as 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
注释里可以加几个示例,说明一下这是什么情况
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已添加
| } | ||
| } | ||
| | ||
| bool IsEinsumOuter(const std::string& equation) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上,可以注释加一些示例说明
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已添加
| bool IsEinsumOuter(const std::string& equation) { | ||
| std::vector<std::string> inputs; | ||
| std::string output; | ||
| ParseEinsumEquation(equation, &inputs, &output); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里在调用之前有 ParseEinsumEquation 了,是不是不用调用了,直接把参数传进来?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯嗯,我改了一下
| /re-run all-failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Category
Auto Parallel
PR Types
New features
Description
为
einsum算子增加 spmd rule