Skip to content

[AutoParallel] remove sharding fuse flags #73744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 8, 2025
Merged

[AutoParallel] remove sharding fuse flags #73744

merged 4 commits into from
Jul 8, 2025

Conversation

@waliwali777
Copy link
Contributor

@waliwali777 waliwali777 commented Jul 1, 2025 •
edited
Loading

PR Category

Auto Parallel

PR Types

Performance

Description

移除 sharding stage1 fuse comm 添加的 flag（ #72120 ），该优化以后默认开启
PCard-90131
@paddle-bot
Copy link

paddle-bot bot commented Jul 1, 2025

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 85.71429% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (develop@e991019). Learn more about missing BASE report.

Files with missing lines Patch % Lines
python/paddle/distributed/auto_parallel/api.py 85.71% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (85.71%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@ Coverage Diff @@ ## develop #73744 +/- ## ========================================== Coverage ? 85.71% ========================================== Files ? 1 Lines ? 28 Branches ? 0 ========================================== Hits ? 24 Misses ? 4 Partials ? 0

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
This was referenced Jul 2, 2025
Merged
Merged
@waliwali777
Copy link
Contributor Author

/re-run all-failed
@waliwali777
Copy link
Contributor Author

/re-run all-failed
liym27
liym27 reviewed Jul 7, 2025
View reviewed changes
python/paddle/distributed/auto_parallel/api.py Outdated
should be `shard(0)` if possible.
e.g.
a) sharding_axis = 0, tensor rank = 2,
placements: [partial, partial, partial] -> [shard(0), shard(1), replicate]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shard(0) -> Shard(0), replicate-> Repliacate(), ...
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thx
@waliwali777
Copy link
Contributor Author

/re-run all-failed
1 similar comment
@waliwali777
Copy link
Contributor Author

/re-run all-failed
liym27
liym27 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@waliwali777
Copy link
Contributor Author

/re-run approval
@waliwali777
Copy link
Contributor Author

/re-run approval
@liym27 liym27 merged commit a94d700 into PaddlePaddle:develop Jul 8, 2025
54 of 56 checks passed
@waliwali777 waliwali777 mentioned this pull request Jul 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-ci: coverage

5 participants

@waliwali777 @codecov-commenter @tianshuo78520a @liym27 @XieYunshen