Skip to content

Conversation

@lshpku
Copy link
Contributor

@lshpku lshpku commented Jun 22, 2025

PR Category

Operator Mechanism

PR Types

New features

Description

新增paddle.incubate.nn.functional.moe_combine_no_weightop及其反向

Pcard-85711

@paddle-bot
Copy link

paddle-bot bot commented Jun 22, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@lshpku lshpku force-pushed the moe-combine-no-weight branch 2 times, most recently from 1d3e4ca to a28c362 Compare June 22, 2025 10:05
@lshpku lshpku force-pushed the moe-combine-no-weight branch from a28c362 to 2ba7ae4 Compare June 22, 2025 10:35
@lshpku lshpku force-pushed the moe-combine-no-weight branch from 27e782f to cd57c5d Compare June 22, 2025 13:47
@lshpku lshpku force-pushed the moe-combine-no-weight branch from cd57c5d to ed8bb03 Compare June 23, 2025 01:09
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

const MetaTensor& scatter_index,
MetaTensor* y);

void MoeCombineNoWeightInferMeta(const MetaTensor& x,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该是binary的

Copy link
Contributor Author

@lshpku lshpku Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个算子之后会按API正确性的要求重写,我看了下它现在不支持大Tensor也不支持0-Size,这次算子迁移的任务太匆忙,只有半天时间,我也没来得及检查

@lshpku lshpku merged commit 53919d3 into PaddlePaddle:develop Jun 23, 2025
72 of 75 checks passed
lshpku added a commit to lshpku/Paddle that referenced this pull request Jun 23, 2025
From00 pushed a commit to From00/Paddle that referenced this pull request Jun 24, 2025
* Add moe_combine_no_weight op * Remove seqlen and k from parameters * Set no_need_buffer for x
swgu98 pushed a commit that referenced this pull request Jun 24, 2025
* Add moe_combine_no_weight op (#73531) * Add moe_combine_no_weight op * Remove seqlen and k from parameters * Set no_need_buffer for x * Add moe_combine_no_weight Op * Update --------- Co-authored-by: Shuhao Liang <50269654+lshpku@users.noreply.github.com>
From00 added a commit to From00/Paddle that referenced this pull request Jun 24, 2025
* Add moe_combine_no_weight op (PaddlePaddle#73531) * Add moe_combine_no_weight op * Remove seqlen and k from parameters * Set no_need_buffer for x * Add moe_combine_no_weight Op * Update --------- Co-authored-by: Shuhao Liang <50269654+lshpku@users.noreply.github.com>
XiaoguangHu01 pushed a commit that referenced this pull request Jun 25, 2025
* Add moe_combine_no_weight OP (#73592) * Add moe_combine_no_weight op (#73531) * Add moe_combine_no_weight op * Remove seqlen and k from parameters * Set no_need_buffer for x * Add moe_combine_no_weight Op * Update --------- Co-authored-by: Shuhao Liang <50269654+lshpku@users.noreply.github.com> * Empty-Commit --------- Co-authored-by: Shuhao Liang <50269654+lshpku@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants