[SOT] Fix guarded fns is not inplace update #73511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
SigureMo changed the title There was a problem hiding this comment.
Pull Request Overview
Ensures that the guarded_fns list is updated in-place when moving a hit to the front, fixing the previous non-in-place reassignment.
- Switched from rebinding
guarded_fnsto using slice assignment for in-place update.
Comments suppressed due to low confidence (1)
python/paddle/jit/sot/opcode_translator/executor/executor_cache.py:268
- Add a unit test to verify that accessing a guarded function moves it to the front of
guarded_fnsin-place, ensuring this behavior is covered.
guarded_fns[:] = [ | # Note: Be cautious when modifying the order of elements in a list during iteration, | ||
| # as it can lead to unexpected behavior. | ||
| guarded_fns = [ | ||
| guarded_fns[:] = [ |
There was a problem hiding this comment.
[nitpick] Consider using guarded_fn = guarded_fns.pop(index); guarded_fns.insert(0, guarded_fn) for a more idiomatic in-place move that avoids allocating a new list.
gouzil approved these changes Jun 21, 2025
SigureMo changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
Execute Infrastructure
PR Types
Bug fixes
Description
#73506 中实现的 move to front 并没有 inplace 修改，因此实际上并没有生效，本 PR 修复