Skip to content

Conversation

@YqGe585
Copy link
Contributor

@YqGe585 YqGe585 commented Jun 16, 2025

PR Category

Custom Device

PR Types

Bug fixes

Description

pcard-67164
Rename the conflicting variables to avoid collision with the system macro defined in some environment.

@YqGe585 YqGe585 changed the title Fix major and minor redefined bug Rename the conflicting variables Jun 16, 2025
@paddle-bot
Copy link

paddle-bot bot commented Jun 16, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

std::string name;
int major = 0;
int minor = 0;
int DeviceMajor = 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

命名有问题,驼峰没问题,需要首字母小写

DeviceProp(const std::string& name_,
int major_,
int minor_,
int DeviceMajor_,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同样的命名问题

Copy link
Contributor

@yongqiangma yongqiangma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yongqiangma yongqiangma merged commit 1726bf0 into PaddlePaddle:develop Jun 18, 2025
71 of 74 checks passed
@YqGe585 YqGe585 deleted the DeviceProp branch June 18, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants