[Auto Parallel] Fix pp_degree > 1 bug for sharding overlap in auto dy #73142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
liym27 reviewed Jun 9, 2025
| if "pp" in fleet.auto.get_mesh().dim_names: | ||
| param_group_len = ( | ||
| param_group_len * fleet.auto.get_mesh().get_dim_size("pp") | ||
| ) |
There was a problem hiding this comment.
这里是指还有 vpp_degree 吗？
There was a problem hiding this comment.
不是，pp 是自定义的一个名称，虽然默认用 "pp" 来命名 流水线并行，但也可以用其它名称。因为框架其它多处使用该命名，可先保持一致，后续再统一。
liym27 approved these changes Jun 9, 2025
shanjiang7 pushed a commit to shanjiang7/Paddle that referenced this pull request Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
Auto Parallel
PR Types
Bug fixes
Description
FLAGS_enable_sharding_overlap = true/falsein pp_degree > 1.Pcard-70448