Skip to content

Conversation

@NKNaN
Copy link
Contributor

@NKNaN NKNaN commented Jun 6, 2025

PR Category

Auto Parallel

PR Types

New features

Description

为 depthwise_conv2d 和 depthwise_conv2d_grad 算子增加切分推导规则。

  • input 和 filter 的 channel 维不进行切分:filter 的 channel 维大小总是 1,若将 input 的 channel 维切分到不同设备,则在不同设备上需要将 group 参数也改为对应的大小才能正确计算,所以暂时对 channel 维不做切分。
  • 其他规则与 conv2d, conv3d 一致
@paddle-bot
Copy link

paddle-bot bot commented Jun 6, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-ci-bot
Copy link

paddle-ci-bot bot commented Jun 15, 2025

Sorry to inform you that b4e6c54's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually.

if (data_format == "NCHW")
input_dims_mapping[1] == -1;
else
input_dims_mapping[3] == -1;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

== -> =,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

filter_dist_attr_src,
filter_dist_attr_dst);
LogOutputDistAttr("Output", output_dist_attr_dst);
VLOG(4) << std::endl;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

partial 状态的处理可以加个注释

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已增加

)

# case 4
# input: NCHinWin[-1, 0, -1, -1], filter: MCHkWk[-1, -1, -1, -1] ---> output: NMHoutWout[-1, -1, -1, -1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C强制设置为-1,这里注释说明一下是自动reset

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已增加

)

# case 5
# input: NCHinWin[0, 2, -1, -1], filter: MCHkWk[1, -1, -1, -1] ---> output: NMHoutWout[0, 1, -1, -1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已增加

)

# case 4
# input: NHinWinC[-1, -1, -1, 0], filter: MCHkWk[-1, -1, -1, -1] ---> output: NMHoutWout[-1, -1, -1, -1]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

同上

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已增加

@luotao1
Copy link
Contributor

luotao1 commented Jun 20, 2025

@NKNaN
Copy link
Contributor Author

NKNaN commented Jun 20, 2025

#72415 (comment)

@NKNaN 请知晓

了解了

@NKNaN NKNaN force-pushed the depthwise-spmd branch 2 times, most recently from 6fba46f to dc4e31e Compare June 23, 2025 12:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 98.98990% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (develop@d8130a4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...addle/phi/infermeta/spmd_rules/depthwise_conv2d.cc 98.98% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## develop #73134 +/- ## ========================================== Coverage ? 98.98% ========================================== Files ? 1 Lines ? 99 Branches ? 0 ========================================== Hits ? 98 Misses ? 1 Partials ? 0 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@NKNaN
Copy link
Contributor Author

NKNaN commented Jun 30, 2025

/re-run all-failed

@NKNaN
Copy link
Contributor Author

NKNaN commented Jul 1, 2025

CI 应该可以了

danleifeng
danleifeng previously approved these changes Jul 2, 2025
Copy link
Contributor

@danleifeng danleifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zyfncg
zyfncg previously approved these changes Jul 4, 2025
@luotao1
Copy link
Contributor

luotao1 commented Jul 4, 2025

需要解决下冲突

@NKNaN
Copy link
Contributor Author

NKNaN commented Jul 4, 2025

/re-run all-failed

@luotao1 luotao1 merged commit 89bdb53 into PaddlePaddle:develop Jul 7, 2025
97 of 104 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers HappyOpenSource Pro 进阶版快乐开源活动,更具挑战性的任务 skip-ci: approval

7 participants