-
Couldn't load subscription status.
- Fork 5.9k
[Auto Parallel] Add spmd rule No.16 for depthwise_conv2d and depthwise_conv2d_grad ops. #73134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 你的PR提交成功,感谢你对开源项目的贡献! |
| Sorry to inform you that b4e6c54's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
| if (data_format == "NCHW") | ||
| input_dims_mapping[1] == -1; | ||
| else | ||
| input_dims_mapping[3] == -1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
== -> =,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已修改
| filter_dist_attr_src, | ||
| filter_dist_attr_dst); | ||
| LogOutputDistAttr("Output", output_dist_attr_dst); | ||
| VLOG(4) << std::endl; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
partial 状态的处理可以加个注释
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已增加
| ) | ||
| | ||
| # case 4 | ||
| # input: NCHinWin[-1, 0, -1, -1], filter: MCHkWk[-1, -1, -1, -1] ---> output: NMHoutWout[-1, -1, -1, -1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C强制设置为-1,这里注释说明一下是自动reset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已增加
| ) | ||
| | ||
| # case 5 | ||
| # input: NCHinWin[0, 2, -1, -1], filter: MCHkWk[1, -1, -1, -1] ---> output: NMHoutWout[0, 1, -1, -1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已增加
| ) | ||
| | ||
| # case 4 | ||
| # input: NHinWinC[-1, -1, -1, 0], filter: MCHkWk[-1, -1, -1, -1] ---> output: NMHoutWout[-1, -1, -1, -1] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已增加
了解了 |
6fba46f to dc4e31e Compare Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #73134 +/- ## ========================================== Coverage ? 98.98% ========================================== Files ? 1 Lines ? 99 Branches ? 0 ========================================== Hits ? 98 Misses ? 1 Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /re-run all-failed |
| CI 应该可以了 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| 需要解决下冲突 |
| /re-run all-failed |
PR Category
Auto Parallel
PR Types
New features
Description
为 depthwise_conv2d 和 depthwise_conv2d_grad 算子增加切分推导规则。