Skip to content

add back priority #7294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 8, 2018
Merged

add back priority #7294

merged 3 commits into from
Jan 8, 2018
+23 −7

Conversation

@jacquesqiao
Copy link
Member

@jacquesqiao jacquesqiao commented Jan 8, 2018 •
edited
Loading

fix: #7300
@jacquesqiao jacquesqiao requested a review from dzhwinter January 8, 2018 08:43
dzhwinter
dzhwinter previously approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM，if there is any performance concern, we can enhance it after experiment proving its a real bottle-neck.
dzhwinter
dzhwinter approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@dzhwinter dzhwinter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good
@jacquesqiao jacquesqiao merged commit d762e07 into PaddlePaddle:develop Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@jacquesqiao @dzhwinter