[CINN] Fix int type casting of Scale op #72811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
lshpku changed the title 
zyfncg approved these changes May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
CINN
PR Types
Bug fixes
Description
修复scale op在对int/int64类型进行scale时出现的cast报错
说明：scale默认是用float类型作为乘的参数，之前scale不会用于操作int类型的下标，都是操作浮点类型，所以没问题，而支持arange后出现了scale直接操作下标的场景，就发生类型冲突了
本PR使用common::cast接口替换Cast::Make，前者可以直接对常数进行eager cast，避免出现
int(5.0f)这样矛盾的情况，这会导致后续convert_int32_to_int64报错Pcard-85711