[PHI] implement masked_fill_op and optimize bool setitem indexing #72788
+812 −12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
| @@ -0,0 +1,114 @@ | |||
| // Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved. | |||
There was a problem hiding this comment.
// Copyright (c) 2025
python/paddle/tensor/manipulation.py Outdated
| | ||
| mask = paddle.logical_not(mask) | ||
| out = paddle.where_(mask, x, value) | ||
| out = _C_ops.masked_fill(x, mask, value) |
| | ||
| namespace phi { | ||
| namespace funcs { | ||
| inline bool CanShortCutMaskFill(const DDim& input_dim, const DDim& mask_dim) { |
There was a problem hiding this comment.
这里换个体现函数实际比对功能的名字比较好
changeyoung98 previously approved these changes May 19, 2025
| inline static bool MaskedFillDispatching(const paddle::Tensor& tensor, | ||
| const paddle::Tensor& value, | ||
| std::vector<paddle::Tensor>* indices) { | ||
| if (value.numel() != 1) return false; |
There was a problem hiding this comment.
mask_fill kernel 只支持value 是单值的？
There was a problem hiding this comment.
根据python/paddle/tensor/manipulation.py中对masked_fill参数定义：
value (Scalar or 0-D Tensor): The value used to fill the target tensor.
因此只有value为单值时才可以使用masked_fill
Eddie-Wang1120 changed the title 
zyfncg approved these changes May 21, 2025
Comment on lines +36 to +37
| auto x_grad_dims = x_grad->dims(); | ||
| auto mask_dims = mask.dims(); |
There was a problem hiding this comment.
好的，后面会提交pr修改
Comment on lines +32 to +33
| auto x_dims = x.dims(); | ||
| auto mask_dims = mask.dims(); |
xiaoguoguo626807 merged commit 15e2e47 into PaddlePaddle:develop 53 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
Performance Optimization
PR Types
Improvements
Description
pcard-67164
Kernel Optimization
Masked_Fill forward kernel performance
Masked_Fill backward kernel performance
Logical Optimization
SetItem forward performance
SetItem backward performance