Skip to content

Conversation

@aquagull
Copy link
Contributor

@aquagull aquagull commented May 8, 2025

PR Category

User Experience

PR Types

Others

Description

为paddle.less_than、paddle.less_equal、paddle.greater_than、paddle.greater_equal添加复数类型支持

@paddle-bot
Copy link

paddle-bot bot commented May 8, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label May 8, 2025
class TestLessEqualComplex128Api(op_test.OpTest):
def setUp(self):
self.op_type = 'less_equal'
self.typename = ("float64", "complex128")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的typename[1]是不是可以删掉

Comment on lines +51 to +54
T ar = a.real; \
T br = b.real; \
T ai = a.imag; \
T bi = b.imag; \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的中间变量感觉可以省掉?直接用a.real op b.real

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这两个地方我在之后的PR更改吧

Copy link
Contributor

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 876366b into PaddlePaddle:develop May 9, 2025
46 of 48 checks passed
GITD245 pushed a commit to GITD245/Paddle that referenced this pull request May 14, 2025
…r_equal添加复数类型支持 (PaddlePaddle#72619) * update code * update api * fix less_than
@aquagull aquagull deleted the compare branch August 8, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

2 participants