[SOT][Faster Guard] support object_equal_stringified_guard #72081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
test/sot/test_faster_guard.py:206
- [nitpick] The function 'test_func' is redefined in the same scope, which may cause confusion in the test. Consider using a distinct name (e.g., 'test_func_redefined') for clarity.
def test_func(): 
SigureMo reviewed Apr 5, 2025
| StringifiedExpression( | ||
| FasterStringifiedExpression( | ||
| f"{obj_free_var_name}() is not None and {{}} == {obj_free_var_name}()", | ||
| paddle.framework.core.PyObjMatchGuard(self.get_py_value()), |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
SigureMo reviewed Apr 6, 2025
paddle/fluid/pybind/sot/guards.h Outdated
| Py_INCREF(expected_); | ||
| } | ||
| | ||
| ~PyObjMatchGuard() override { Py_DECREF(expected_); } |
There was a problem hiding this comment.
好家伙，真就直接不 INCREF 存裸指针是吧，话说 weakref 本质上就是存不加引用计数的裸指针吗？
另外，如果是这样的话，使用的时候得检查下是否还存在，如果不存在的话记得报个错
SigureMo reviewed Apr 7, 2025
paddle/fluid/pybind/sot/guards.h Outdated
| PyObject* expected_; | ||
| }; | ||
| | ||
| class PyObjMatchGuard : public GuardBase { |
There was a problem hiding this comment.
Suggested change
| class PyObjMatchGuard : public GuardBase { | |
| class WeakRefMatchGuard : public GuardBase { |
就叫这个吧，和 ValueMatchGuard 作区分
paddle/fluid/pybind/sot/guards.cc Outdated
| } | ||
| | ||
| #if PY_3_13_PLUS | ||
| PyObject* referent = NULL; |
There was a problem hiding this comment.
referent 是啥，引用吗？应该是 reference 吧？一般直接写 ref 就可以吧
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
Performance Optimization
PR Types
Performance
Description
NumpyDtypeMatchGuard->NumPyDtypeMatchGuardWeakRefMatchGuard用于对自身进行弱引用，在 check 的时候检查自身是否为 None，并且于传入值相等