Skip to content

Conversation

@zhouquan32
Copy link
Contributor

PR Category

Custom Device

PR Types

New features

Description

support take_along_axis_grad in XPU

@paddle-bot
Copy link

paddle-bot bot commented Mar 19, 2025

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 19, 2025
@houj04
Copy link
Contributor

houj04 commented Mar 20, 2025

原有单测里面:test/xpu/test_take_along_axis_op_xpu.py
包含有一些类似这样的代码

self.in_type = np.float32

确认一下这里是否会影响到单测的完整性,即,是否真的把所有数据类型都跑到了?
以及,是否需要修改,按照正常的逻辑,这样配合使用。

support_types = get_xpu_op_support_types('take_along_axis') self.dtype = self.in_type
@@ -0,0 +1,92 @@
// Copyright (c) 2022 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里应该是2025,问题不大,可以以后再改,节约流水线资源。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修复

Copy link
Contributor

@zhangyk0314 zhangyk0314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@houj04 houj04 merged commit 2694a29 into PaddlePaddle:develop Mar 24, 2025
32 of 33 checks passed
YqGe585 pushed a commit to YqGe585/Paddle that referenced this pull request May 7, 2025
* xpu: support take_along_axis_grad in XPU * fix test cases for take_along_axis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

3 participants