【Hackathon 6th No.31】paddle.standard_normal and paddle.randn support complex normal distribution -part #65032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
| if core.is_compiled_with_cuda() | ||
| else paddle.CPUPlace() | ||
| ) | ||
| paddle.disable_static(place) |
Contributor
There was a problem hiding this comment.
动态图、静态图的切换建议使用dygraph_guard、static_guard，保证切换不会影响其他单测
| var_imag = out.numpy().imag.var() | ||
| np.testing.assert_allclose(var, 1.0, rtol=0.2, atol=0.2) | ||
| np.testing.assert_allclose(var_real, 0.5, rtol=0.2, atol=0.2) | ||
| np.testing.assert_allclose(var_imag, 0.5, rtol=0.2, atol=0.2) |
Contributor
There was a problem hiding this comment.
此处的误差大概有多少，能否尽量设小点
Contributor Author
There was a problem hiding this comment.
rtol=0.2, atol=0.2参考的是 test_normal 里 TestNormalAPI 类的设置。
改成rtol=0.02, atol=0.02了
| paddle.set_device('gpu') | ||
| test_complex64() | ||
| test_complex128() | ||
| paddle.set_device('cpu') |
Contributor
There was a problem hiding this comment.
尽量不要使用全局性的设置以免影响其他单测，或者测试完成后恢复原先的设置。
luotao1 approved these changes Jun 24, 2024
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Jun 25, 2024
…complex normal distribution -part (PaddlePaddle#65032) * update standard_normal and randn * update standard_normal * revise code examples * update randn * update test * update test * fix test and docs example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Improvements
Description
Upgrade paddle.standard_normal, paddle.randn to support complex normal distribution.
Also add code examples for paddle.normal