Skip to content

typo WITH_TEST to WITH_TESTING #6473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2017
Merged

typo WITH_TEST to WITH_TESTING #6473

merged 2 commits into from
Dec 13, 2017

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Dec 11, 2017

fix #6472
@luotao1 luotao1 requested a review from typhoonzero December 11, 2017 10:32
typhoonzero
typhoonzero reviewed Dec 11, 2017
View reviewed changes
doc/howto/dev/contribute_to_paddle_cn.md Outdated

```bash
➜ docker run -v $(pwd):/paddle -e "WITH_GPU=OFF" -e "WITH_AVX=ON" -e "WITH_TEST=ON" paddle:dev
➜ docker run -v $(pwd):/paddle -e "WITH_GPU=OFF" -e "WITH_AVX=ON" -e "WITH_TESTING=ON" paddle:dev
Copy link
Contributor

@typhoonzero typhoonzero Dec 11, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paddle:dev => paddle:latest-dev ?或者paddle:[version tag]-dev
Copy link
Contributor Author

@luotao1 luotao1 Dec 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, done.
typhoonzero
typhoonzero approved these changes Dec 13, 2017
View reviewed changes
Copy link
Contributor

@typhoonzero typhoonzero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@luotao1 luotao1 merged commit 79f0ab5 into PaddlePaddle:develop Dec 13, 2017
@luotao1 luotao1 deleted the with_test branch December 13, 2017 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@luotao1 @typhoonzero