Skip to content

Conversation

@chengduoZH
Copy link
Contributor

@chengduoZH chengduoZH commented Dec 7, 2017

fix #6393
Currently, the format of equation for img_pool and maxout is very messy.
paddle.v2.layer.img_pool
paddle.v2.layer.maxout

@chengduoZH chengduoZH requested a review from luotao1 December 7, 2017 12:48
@chengduoZH chengduoZH force-pushed the feature/fix_python_api_doc branch from 57302f3 to 7516671 Compare December 7, 2017 12:49
@luotao1
Copy link
Contributor

luotao1 commented Dec 7, 2017

Please paste the current format of the equation, thanks!

@chengduoZH chengduoZH force-pushed the feature/fix_python_api_doc branch from 7516671 to 93563ef Compare December 7, 2017 14:18
@chengduoZH
Copy link
Contributor Author

wx20171207-221959 2x

w = 1 + int(ceil(input\_width + 2 * padding - pool\_size) / float(stride))
w = 1 + int(ceil(input\_width + 2 * padding - pool\_size) / float(stride)) \\\\
h = 1 + int(ceil(input\_height + 2 * padding\_y - pool\_size\_y) / float(stride\_y))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

作为公式的话,int, float是不是去掉,ceil换成对应的取整符号,/变成上下除的格式,显示时会更好看点。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@chengduoZH chengduoZH force-pushed the feature/fix_python_api_doc branch from 201875d to f38a975 Compare December 8, 2017 03:48
@chengduoZH chengduoZH force-pushed the feature/fix_python_api_doc branch from f38a975 to 3c84444 Compare December 8, 2017 04:10
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chengduoZH chengduoZH merged commit b6e67f6 into PaddlePaddle:develop Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants