Skip to content

Conversation

@SigureMo
Copy link
Member

@SigureMo SigureMo commented Apr 2, 2024

PR Category

Execute Infrastructure

PR Types

Others

Description

开启单测 test_sentiment,基于 #63190,SOT 下 PT 和老 IR 有精度问题,暂不排查

移除已经禁用好久了的单测 test_lac(至少当初推 SOT 的时候就禁用掉了),该单测包含 3 个直接裸调 _C_ops 的 API(linear_chain_crfcrf_decodingchunk_eval),根据 3.0 规范,这 3 个 API 均为待删除 API,因此该单测没必要在 PIR 下适配

Pcard-67164

@paddle-bot
Copy link

paddle-bot bot commented Apr 2, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot
Copy link

paddle-bot bot commented Apr 2, 2024

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

@SigureMo SigureMo changed the title [Dy2St][PIR] Add restore_out in PIR sot_call [Dy2St][PIR] Enable PIR ut test_sentiment Apr 2, 2024
@SigureMo SigureMo changed the title [Dy2St][PIR] Enable PIR ut test_sentiment [Dy2St][PIR] Enable PIR ut test_sentiment and remove test_lac Apr 3, 2024
XieYunshen
XieYunshen previously approved these changes Apr 3, 2024
XieYunshen
XieYunshen previously approved these changes Apr 3, 2024
@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 3, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 3, 2024
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SigureMo SigureMo merged commit 1cfefa0 into PaddlePaddle:develop Apr 7, 2024
@SigureMo SigureMo deleted the dy2st/enable-sentiment branch April 7, 2024 07:20
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 9, 2024
co63oc pushed a commit to co63oc/Paddle that referenced this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants