[fix][dataloader] use file descripor instead of file system #62696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
xysheng-baidu force-pushed the fix_data_loader branch 2 times, most recently from b660bf5 to 0d9bf1d Compare xysheng-baidu force-pushed the fix_data_loader branch from 0d9bf1d to efb137d Compare 
| Sorry to inform you that efb137d's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
sneaxiy reviewed Mar 27, 2024
paddle/common/flags.cc Outdated
| * Note: . If True, mmap_allocator will use file descripor to open shared memory | ||
| * operation. | ||
| */ | ||
| PHI_DEFINE_EXPORTED_bool(use_file_descripor, |
Collaborator
There was a problem hiding this comment.
Change it be dataloader_use_file_descriptor.
| # Empty tensors have nothing be mapped. | ||
| return (_rebuild_lodtensor_empty, (type(lodtensor),)) | ||
| inmeta = False | ||
| if os.environ.get('FLAGS_use_file_descripor', True) in [ |
Collaborator
There was a problem hiding this comment.
Change it be core.globals()["FLAGS_use_file_descripor"]. The core is paddle.base.core.
| inmeta | ||
| ) # ipc_name, fd, size, type_idx, dims, lod | ||
| | ||
| if os.environ.get('FLAGS_use_file_descripor', True) in [ |
Collaborator
There was a problem hiding this comment.
Change it be core.globals()["FLAGS_use_file_descripor"]. The core is paddle.base.core.
… fix_data_loader
… fix_data_loader
xysheng-baidu force-pushed the fix_data_loader branch 2 times, most recently from 1ab0976 to 908910b Compare sneaxiy approved these changes Apr 2, 2024
xysheng-baidu added a commit to xysheng-baidu/Paddle that referenced this pull request Apr 2, 2024
…ddle#62696) * [fix][dataloader] use file descripor instead of file system * [fix][dataloader] use core.globals instend of os.environ * [fix][dataloader] add test dataloader * [fix][dataloader] set FLAGS_dataloader_use_file_descriptor on child process
xysheng-baidu added a commit to xysheng-baidu/Paddle that referenced this pull request Apr 2, 2024
xysheng-baidu added a commit to xysheng-baidu/Paddle that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR Category
User Experience
PR Types
Bug fixes
Description
PCard-81023
use file descripor instead of file system in dataloader.