remove final set_value OP in combined-indexing setting #60983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
eee4017 pushed a commit to eee4017/Paddle that referenced this pull request Jan 30, 2024
…60983) * remove setvalue in combined indexing set * using combined-setting case to test
zoooo0820 added a commit to zoooo0820/Paddle that referenced this pull request Feb 27, 2024
…60983) * remove setvalue in combined indexing set * using combined-setting case to test
zoooo0820 added a commit to zoooo0820/Paddle that referenced this pull request Feb 27, 2024
…60983) * remove setvalue in combined indexing set * using combined-setting case to test
XiaoguangHu01 pushed a commit that referenced this pull request Feb 28, 2024
* tensor_array slice in PIR (#60503) * use slice_array, now will meet error of destory opresult still in use * disable the pir test until the bug fixed * Optimize advanced setting by remove the last set_value (#60771) * pure-advanced setitem will not set_value back * fix multi output in tensor_array_pir * only in dynamic mode * add only advanced-setting case to fix coverage * fast pass for bool setitem (#61021) * fast pass for bool setitem * fix 0-size value case * remove final set_value OP in combined-indexing setting (#60983) * remove setvalue in combined indexing set * using combined-setting case to test * Optimize index put preprocess (#61060) * reduce vector operations when no bool index * reduce vector in index_put * reduce vector operations * no change for value * fix shape error in combine-getitem (#61922)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Description
Pcard-66985
For combined indexing setting case of dynamic mode, e.g.
x[1, [0,1]] = value, we will deal it as following step:x'=x[1]set_value.In our plan , if
xhas changed byvalue, the backward should contain it too.But for now., in step 2, the x cannot know whether it has been changed by other operators. It will only backward to the OP which generated it instead of which modified it.
In past , the step 3 is aiming to build a backward edge between
valueandx. But the performance suffers because of unnecessary forward overwrite.This PR is to optimize this case by remove the final
set_value_with_tensor, only keeping the backward part , to build a edge between value and x.