【PIR OpTest Fix No.15】 fix test match matrix tensor op #60277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Closed
kangguangli previously approved these changes Dec 25, 2023
zyfncg reviewed Dec 26, 2023
paddle/phi/infermeta/multiary.cc Outdated
Comment on lines 2919 to 2943
| if (config.is_runtime) { | ||
| const auto& x_lod = x.lod(); | ||
| PADDLE_ENFORCE_EQ(x_lod.empty(), | ||
| false, | ||
| phi::errors::InvalidArgument( | ||
| "The Input(X) should hold LoD information, but " | ||
| "received Input(X).lod() is empty.")); | ||
| const auto& x_lod_0 = x_lod[0]; | ||
| PADDLE_ENFORCE_GE(x_lod_0.size(), | ||
| 2, | ||
| phi::errors::InvalidArgument( | ||
| "The dimensions of Input(X)'s LoD data should be " | ||
| "equal to 2, but received %d.", | ||
| x_lod_0.size())); | ||
| PADDLE_ENFORCE_EQ(x_dims[0], | ||
| static_cast<int64_t>(x_lod_0.back()), | ||
| phi::errors::InvalidArgument( | ||
| "The last element of Input(X)'s LoD data should be " | ||
| "equal to the first dimension of Input(X). " | ||
| "But received the last element of Input(X)'s LoD " | ||
| "data is %d, the first dimension of Input(X) is %d.", | ||
| x_lod_0.back(), | ||
| x_dims[0])); | ||
| | ||
| const auto& y_lod = y.lod(); |
There was a problem hiding this comment.
如果lod信息仅在runtime时计算，是否可以将此处的计算逻辑放在kernel里？这样就不必将MetaTensor中的lod接口暴露出来。
There was a problem hiding this comment.
这里主要是用lod信息推导tmp和out的ddim信息，这些可以在kernel里再设置吗？
There was a problem hiding this comment.
这里是运行时的处理，infermeta里写和在kernel里写是等价的
| Sorry to inform you that 14ac734's CIs have passed for more than 7 days. To prevent PR conflicts, you need to re-run all CIs manually. |
kangguangli previously approved these changes Jan 16, 2024
paddle/phi/infermeta/multiary.cc Outdated
| | ||
| int64_t out_dim_0 = -1; | ||
| int64_t tmp_dim_0 = -1; | ||
| if (!config.is_runtime) { |
zyfncg reviewed Jan 16, 2024
paddle/phi/infermeta/multiary.cc Outdated
Comment on lines 2898 to 2904
| void MatchMatrixTensorInferMeta(const MetaTensor& x, | ||
| const MetaTensor& y, | ||
| const MetaTensor& w, | ||
| int dim_t, | ||
| MetaTensor* out, | ||
| MetaTensor* tmp, | ||
| MetaConfig config) { |
paddle/phi/infermeta/multiary.cc Outdated
Comment on lines 2964 to 2965
| out->set_dims(common::make_ddim(out_dims_vec)); | ||
| tmp->set_dims(common::make_ddim(tmp_dims_vec)); |
kangguangli approved these changes Jan 23, 2024
zyfncg approved these changes Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
PIR Op单测修复
修复单测
test match matrix tensor op修复后打开
FLAGS_enable_pir_in_executor单测是否通过：否报错信息：