Refine install docs #5943
Merged
Refine install docs #5943
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
luotao1 reviewed Nov 28, 2017
| | ||
| .. code-block:: bash | ||
| docker run -it -v $PWD:/paddle -e "WITH_GPU=OFF" -e "WITH_TESTING=OFF" -e "RUN_TEST=ON" paddlepaddle/paddle_manylinux_devel:cuda8.0_cudnn5 bash -x paddle/scripts/docker/build.sh |
There was a problem hiding this comment.
- WITH_TESTING和RUN_TEST是什么关系呢，为什么一个是OFF，一个是ON？
- WITH_GPU=OFF的话，只能测试cpu的单测，gpu的单测测不了，是不是要和用户说一下？
| mkdir build | ||
| cd build | ||
| cmake -DWITH_GPU=OFF -DWITH_TESTING=OFF .. |
There was a problem hiding this comment.
DWITH_TESTING=OFF应该是ON吧。- ctest的命令，还可以用
make test ARG='-j 4'，可以一起加上么？ - 这里只列出了跑所有单测的命令，还可以加上跑指定单测的命令：
make test ARGS="-R test_mul_op -V"和ctest -R test_mul_op
参考：https://github.com/PaddlePaddle/Paddle/blob/develop/doc/howto/dev/new_op_cn.md#编译和执行单元测试
There was a problem hiding this comment.
ctest的命令，还可以用make test ARG='-j 4'，可以一起加上么？
这个感觉不用吧，只保留一种执行test的方式，避免费解。
其他的Comments都更新了。感谢Review~
| 我们推荐您使用PaddlePaddle Docker编译环境镜像完成编译，这样可以免去单独安装编译依赖的步骤，可选的不同编译环境Docker镜像 | ||
| 可以在 `这里 <https://hub.docker.com/r/paddlepaddle/paddle_manylinux_devel/tags/>`_ 找到。 | ||
| | ||
| 如果您选择不使用Docker镜像，则需要在本机安装下面章节列出的“编译依赖”之后才能开始编译的步骤。 |
There was a problem hiding this comment.
“编译依赖” 这里可以加链接么？即直接跳转到后面的内容
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #5941