Skip to content

Fix latex syntax in bilinear tensor product operator comment. #5875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 24, 2017
Merged

Fix latex syntax in bilinear tensor product operator comment. #5875

merged 2 commits into from
Nov 24, 2017
+13 −5

Conversation

@peterzhang2029
Copy link
Contributor

resolve #5874
@peterzhang2029 peterzhang2029 changed the title Refine docstring of bilinear tensor product operator. Fix latex syntax in bilinear tensor product operator comment. Nov 23, 2017
lcy-seso
lcy-seso reviewed Nov 23, 2017
View reviewed changes
paddle/operators/bilinear_tensor_product_op.cc Outdated
Out_i = \sum_j {M_j} + Bias_i
$$
Where $$W_i$$ is the i-th slice of Input(Weight);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

双 $$ 括起来的是独立成行的公式，行内符号请用单$。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
lcy-seso
lcy-seso reviewed Nov 23, 2017
View reviewed changes
paddle/operators/bilinear_tensor_product_op.cc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i --> $i = 1, . . . , k $
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
paddle/operators/bilinear_tensor_product_op.cc Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的 i 和 j 都用Latex符号表示：$i$, $j$
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.
lcy-seso
lcy-seso approved these changes Nov 23, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@peterzhang2029 peterzhang2029 merged commit 1ab1b09 into PaddlePaddle:develop Nov 24, 2017
@peterzhang2029 peterzhang2029 deleted the refine_op_doc branch November 24, 2017 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@peterzhang2029 @lcy-seso