Skip to content

add dot_prod_layer #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2017
Merged

add dot_prod_layer #5724

merged 2 commits into from
Nov 17, 2017

Conversation

@ranqiu92
Copy link
Contributor

@ranqiu92 ranqiu92 commented Nov 17, 2017 •
edited by lcy-seso
Loading

fixes #5496
@ranqiu92 ranqiu92 requested a review from lcy-seso November 17, 2017 06:01
lcy-seso
lcy-seso reviewed Nov 17, 2017
View reviewed changes
paddle/gserver/tests/test_LayerGrad.cpp Outdated
config.layerConfig.add_inputs();

for (auto useGpu : {false, true}) {
testLayerGrad(config, "dot_prod", 100, false, useGpu);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的batch size 改小一些，不需要用这么大的batch size 跑单测。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
python/paddle/trainer_config_helpers/layers.py
size=l.config.size)


@wrap_name_default()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要为helper 加单测。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
lcy-seso
lcy-seso reviewed Nov 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
doc/api/v2/config/layer.rst Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要像339行那样的横线。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
paddle/gserver/layers/DotProdLayer.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

句末加上句号吧~
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
paddle/gserver/layers/DotProdLayer.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1UL
  • The output dimensionality of this layer should be fixed to 1.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
python/paddle/trainer/config_parser.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

完整的一句话注释之后加上句号吧。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
lcy-seso
lcy-seso previously approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
lcy-seso
lcy-seso reviewed Nov 17, 2017
View reviewed changes
python/paddle/trainer/config_parser.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里加一个检测，检查一下两个输入的维度必须相同。

self.get_input_layer(0).size == self.get_input_layer(1).size
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
paddle/gserver/layers/DotProdLayer.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里检查一下 inv0 和 inv1 的宽度必须相同。
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done
lcy-seso
lcy-seso approved these changes Nov 17, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@ranqiu92 ranqiu92 merged commit 093c526 into PaddlePaddle:develop Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ranqiu92 @lcy-seso