Skip to content

Conversation

@kangguangli
Copy link
Contributor

@kangguangli kangguangli commented Apr 7, 2023

PR types

Others

PR changes

APIs

Describe

Add a new BuildStrategy: force_sequential_run, which will let the operations run by the order in the Program.

Other

Pcard-67004

@paddle-bot
Copy link

paddle-bot bot commented Apr 7, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@kangguangli kangguangli force-pushed the add_force_sequential_run_mode branch from 67e0cfc to 7c3cd59 Compare April 7, 2023 13:05
Copy link
Contributor

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better config name is required.
We already have a config FLAGS named sequential_run, therefore force_sequential_run is confusing. It is recommended to reuse the existing name since they have the same semantics.

@kangguangli
Copy link
Contributor Author

A better config name is required. We already have a config FLAGS named sequential_run, therefore force_sequential_run is confusing. It is recommended to reuse the existing name since they have the same semantics.

@zhiqiu Do you have any suggestions? I'll change the name in next PR.

@kangguangli kangguangli merged commit e1692dc into PaddlePaddle:develop Apr 8, 2023
@kangguangli kangguangli deleted the add_force_sequential_run_mode branch April 8, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants