[phi decoupling] move sequence_padding from fluid to phi #50639
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
YuanRisheng reviewed Feb 20, 2023
| #ifdef PADDLE_WITH_XPU | ||
| template <typename T> | ||
| class UnpaddingLoDTensorFunctor<platform::XPUDeviceContext, T> { | ||
| class UnpaddingLoDTensorFunctor<paddle::platform::XPUDeviceContext, T> { |
There was a problem hiding this comment.
XPUDeviceContext替换成phi下的XPUContext
| cpu_seq.set_lod(lod); | ||
| cpu_seq.mutable_data<T>(seq_dims, paddle::platform::CPUPlace()); | ||
| auto *dev_ctx = static_cast<phi::CPUContext *>( | ||
| paddle::platform::DeviceContextPool::Instance().Get(phi::CPUPlace())); |
There was a problem hiding this comment.
这里不需要使用从全局单例里拿对象，可以试试参数传入的context行不行
There was a problem hiding this comment.
这个改成参数传入的 context 之后 CI-Windows 上的 sequence_padding 单测没办通过，我也不太清楚原因:cry:
huangjiyi force-pushed the decouple_sequence_padding branch from 8149f88 to 977527d Compare YuanRisheng approved these changes Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe