Skip to content

rename sparse_vector to sparse_float_vector, and fix typo #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2017
Merged

rename sparse_vector to sparse_float_vector, and fix typo #4968

merged 3 commits into from
Oct 23, 2017

Conversation

@luotao1
Copy link
Contributor

@luotao1 luotao1 commented Oct 20, 2017

fix #4965
@luotao1 luotao1 requested a review from lcy-seso October 20, 2017 09:42
lcy-seso
lcy-seso approved these changes Oct 23, 2017
View reviewed changes
Copy link
Contributor

@lcy-seso lcy-seso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lcy-seso lcy-seso merged commit 43d6981 into PaddlePaddle:develop Oct 23, 2017
@luotao1 luotao1 deleted the sparse_vector branch October 25, 2017 09:39
@Yancey0623 Yancey0623 mentioned this pull request Mar 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@luotao1 @lcy-seso