Skip to content

fix elementwise add bug #4941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2017
Merged

fix elementwise add bug #4941

merged 1 commit into from
Oct 20, 2017
+29 −7

Conversation

@QiJune
Copy link
Member

@QiJune QiJune commented Oct 19, 2017 •
edited
Loading

Fix #4943
Please refer to the ci result in #4942
@QiJune QiJune requested a review from gongweibao October 19, 2017 21:57
gongweibao
gongweibao approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@gongweibao gongweibao left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 @QiJune ,一开始把product(y_dim)==1 当成scalar了。

LGTM!
@QiJune QiJune merged commit 9236917 into PaddlePaddle:develop Oct 20, 2017
@QiJune QiJune mentioned this pull request Oct 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@QiJune @gongweibao