Split paddle_capi_whole into paddle_nn_engine and paddle_layers two s… #4932
+29 −14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Xreki reviewed Oct 19, 2017
paddle/capi/CMakeLists.txt Outdated
| # No shared library for iOS | ||
| # Link the static library for inference | ||
| cc_library(paddle_nn_engine DEPS paddle_capi paddle_utils paddle_parameter paddle_math paddle_cuda paddle_proto) | ||
| cc_library(paddle_layers DEPS paddle_function paddle_gserver) |
There was a problem hiding this comment.
About the libraries' name, how about to name them paddle_capi_engine and paddle_capi_layers?
paddle/capi/CMakeLists.txt Outdated
| install(FILES ${CMAKE_CURRENT_BINARY_DIR}/config.h DESTINATION include/paddle) | ||
| if(ANDROID) | ||
| install(TARGETS paddle_capi_whole paddle_capi_shared | ||
| install(TARGETS paddle_nn_engine paddle_layers paddle_capi_shared |
There was a problem hiding this comment.
Do we need to install paddle_capi_whole for a period of time?
Xreki reviewed Oct 20, 2017
paddle/capi/CMakeLists.txt Outdated
| paddle_proto | ||
| paddle_pserver | ||
| paddle_network) | ||
| cc_library(paddle_capi_whole DEPS paddle_capi ${PADDLE_CAPI_INFER_LIBS}) |
There was a problem hiding this comment.
line 53 is the same as line 41. It can be moved out of the if statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
…tatic libraries.
Here is a use case PaddlePaddle/Mobile#13.