Removing updates of Beta1 and Beta2 power accumulators outside the op #4925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| beta2_pow_out = beta2_pow * beta2 | ||
| learning_rate_t = learning_rate_t * | ||
| sqrt(1 - beta2_pow_out) / (1 - beta1_pow_out) | ||
| sqrt(1 - beta2_pow) / (1 - beta1_pow) |
There was a problem hiding this comment.
Looks like we no longer need to update beta_pow to beta_pow * beta inside the operatorKernel. I am wondering when and where will beta_pow be updated?
There was a problem hiding this comment.
We do not need these because beta1 and beta2 power accumulators will be constant for all parameters. On the other hand, we will have one instance of the adam_op for every parameter. So these will be done in accumulators that the Python API will control.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #4909