[PHI decouple] move dropout_impl and cuda_graph_with_memory_pool from fluid to phi #49139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 你的PR提交成功，感谢你对开源项目的贡献! |
huangjiyi changed the title 
| @YuanRisheng 帮忙 Review 一下 |
YuanRisheng reviewed Dec 19, 2022
| phi::DenseTensor seed_cpu_tensor; | ||
| paddle::framework::TensorCopySync( | ||
| *seed, platform::CPUPlace(), &seed_cpu_tensor); | ||
| phi::Copy(dev_ctx, *seed, phi::CPUPlace(), false, &seed_cpu_tensor); |
There was a problem hiding this comment.
这里是同步拷贝，对应phi下copy参数应该是true
| @YuanRisheng 可以review了 |
YuanRisheng approved these changes Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
dropout_impl.cu.handdropout_impl_util.hfrom fluid to phi.cuda_graph_with_memory_pool.hfrom fluid to phi.cuda_graph.hfrom fluid to phi.