Sparse Kernel for Lookup Table Grad Operator #4904
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
QiJune changed the title 
jacquesqiao reviewed Oct 19, 2017
paddle/framework/operator.h Outdated
| return true; | ||
| } | ||
| | ||
| const Variable* InputVar(const std::string& name) const { |
There was a problem hiding this comment.
why should add two special interfaces
There was a problem hiding this comment.
@jacquesqiao Since we will set var type in compile-time. And our programDesc will pass to Executor to create variable. So we should set variable in Executor. Like GetMutable<Tensor>/GetMutable<SelectedRows>/GetMutable<LoDTensor>.
At run-time, we can just get tensor to set dims and get dims.
Currently, we do not implement variable type inference in Executor. And variable type is set to LoDTensor by default at run-time infershape stage.
I add these two interfaces to get a variable at run-time infershape stage and set variable type manaully. This will be fixed if our whole compile-time framework is done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.