Copy Constructor for ProgramDesc #4895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
and Rename `Sync` to `Flush`
Since lots of types can be cast to bool
…oung/Paddle into dev_impl_conv2d_layer
… dev_impl_conv2d_layer
… dev_impl_conv2d_layer
…_global_instance_of_program
…_global_instance_of_program
…_global_instance_of_program
…reyoung/Paddle into fix_backward_bug
…_global_instance_of_program
…_global_instance_of_program
…_global_instance_of_program
…_global_instance_of_program
…/copy_ctor_program_des
…_global_instance_of_program
…/copy_ctor_program_des
… fix_backward_bug
… fix_backward_bug
reyoung changed the title 
JiayiFeng reviewed Oct 18, 2017
| for (size_t i = 0; i < global_block->OpSize(); ++i) { | ||
| auto op_origin = global_block->Op(i); | ||
| auto op_copy = global_block->Op(i); | ||
| ASSERT_EQ(op_copy->Proto()->SerializeAsString(), |
There was a problem hiding this comment.
I think we shall check they are not the same op first?
| assert start_index is not None | ||
| assert end_index is not None | ||
| assert start_index <= end_index | ||
| if len(self.ops) != 0: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #4896
Note: #4894 is merged into this PR, please review and merge #4894 first.