Skip to content

Correct OpWithKernel's infershape #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2017
Merged

Correct OpWithKernel's infershape #4847

merged 1 commit into from
Oct 17, 2017

Conversation

@reyoung
Copy link
Collaborator

@reyoung reyoung commented Oct 16, 2017

They are public now
@reyoung reyoung requested a review from jacquesqiao October 16, 2017 23:04
@jacquesqiao
Copy link
Member

why are they need to be public?
jacquesqiao
jacquesqiao approved these changes Oct 17, 2017
View reviewed changes
Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@reyoung reyoung merged commit 73a8b78 into PaddlePaddle:develop Oct 17, 2017
@reyoung reyoung deleted the feature/correct_protecteed branch October 28, 2017 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@reyoung @jacquesqiao