Skip to content

[Fluid API] Remove shrink_memory, create_array & array_length #48287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 2, 2022
Merged

[Fluid API] Remove shrink_memory, create_array & array_length #48287

merged 3 commits into from
Dec 2, 2022

Conversation

@HermitSun
Copy link
Contributor

@HermitSun HermitSun commented Nov 23, 2022 •
edited
Loading

PR types

Others

PR changes

APIs

Describe

Clean legacy fluid APIs, including:

  • shrink_memory
  • create_array
  • array_length
@paddle-bot
Copy link

paddle-bot bot commented Nov 23, 2022

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@HermitSun HermitSun force-pushed the fluid-clean branch 3 times, most recently from 426b817 to fb77814 Compare November 29, 2022 12:34
@HermitSun HermitSun changed the title [Fluid API] Remove shrink_memory & array_length in fluid.layers [Fluid API] Remove shrink_memory, create_array & array_length Nov 29, 2022
XieYunshen
XieYunshen approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@XieYunshen XieYunshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for 单测删除
LiYuRio
LiYuRio approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@LiYuRio LiYuRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
jzhang533
jzhang533 approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@jzhang533 jzhang533 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for API removing
JiabinYang
JiabinYang approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@JiabinYang JiabinYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
XiaoguangHu01
XiaoguangHu01 approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@LiYuRio LiYuRio merged commit a686b3c into PaddlePaddle:develop Dec 2, 2022
@HermitSun HermitSun deleted the fluid-clean branch December 2, 2022 02:20
lxsbupt pushed a commit to lxsbupt/Paddle that referenced this pull request Dec 17, 2022
@HermitSun
[Fluid API] Remove shrink_memory, create_array & array_length (P…
abe366b 
…addlePaddle#48287) * refactor: rm shrink_memory * refactor: rm create_array * refactor: rm array_length
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

6 participants

@HermitSun @jzhang533 @JiabinYang @XieYunshen @XiaoguangHu01 @LiYuRio