Feature/parameter #4684
Merged
Feature/parameter #4684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JiayiFeng reviewed Oct 10, 2017
| self._append_initialize_ops_() | ||
| | ||
| def _append_initialize_ops_(self): | ||
| attr = copy.deepcopy(self.init_attr) |
There was a problem hiding this comment.
Why do a deep copy here?
There was a problem hiding this comment.
attr and init_attr will share the same object if we do not deepcopy explicitly. I just keep init_attr unchanged.
| self.proto = self.block.proto.new_var(name) | ||
| try: | ||
| self.desc = self.block.desc.var(name) | ||
| is_new_var = False |
There was a problem hiding this comment.
When will the constructor be called for an existing var?
There was a problem hiding this comment.
Two layers share a same parameter.
| attr = copy.deepcopy(self.init_attr) | ||
| op_type = attr.pop('type', None) | ||
| block = self.block | ||
| assert isinstance(block, Block) |
There was a problem hiding this comment.
Why shall we do this assert?
There was a problem hiding this comment.
Just for IDE type hint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.