Skip to content

Conversation

@Superjomn
Copy link
Contributor

@Superjomn Superjomn commented Sep 22, 2017

resolves: #4344


TEST_F(LoDTensorTester, SliceLevels) {
TEST_F(LoDTensorTester, ShrinkLevels) {
// slice 1 level
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slice => shrink

ASSERT_EQ(new_lod_tensor.NumElements(0), lod_tensor_.NumElements(level));
ASSERT_EQ(new_lod_tensor.data<float>(), lod_tensor_.data<float>());
}
// slice 2 level
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slice => shrink

Copy link
Member

@jacquesqiao jacquesqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! but should change the two comment before merge

@Superjomn Superjomn merged commit fdc4d4a into PaddlePaddle:develop Sep 23, 2017
@Superjomn Superjomn deleted the feature/lod_slice_return_slice branch September 23, 2017 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants