Add bool type for attribute and use it in dropout_op. #4216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
reyoung requested changes Sep 20, 2017
reyoung reviewed Sep 20, 2017
| | ||
| auto dims = ctx.Input<Tensor>("X")->dims(); | ||
| ctx.Output<LoDTensor>("Out")->Resize(dims); | ||
| if (ctx.Attr<int>("is_training") == 1) { |
There was a problem hiding this comment.
Actually, zero is false, and non-zero is true.
reyoung reviewed Sep 20, 2017
| AddAttr<AttrType>("dropout_prob", "Probability of setting units to zero.") | ||
| .SetDefault(.5f); | ||
| // TODO(xinghai-sun): use bool for is_training after bool is supported. | ||
| AddAttr<int>("is_training", "Whether in training phase.").SetDefault(1); |
| Please reference #4239 |
reyoung previously approved these changes Sep 21, 2017
qingqing01 force-pushed the attr_bool branch from f944f95 to 1c428f5 Compare qingqing01 force-pushed the attr_bool branch from 1c428f5 to 0dce16a Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #4215