refine avg-pooling, which is exclusive. refine related code. #4154
+159 −188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
chengduoZH reviewed Sep 18, 2017
| int wstart = pw * strideW - padW; | ||
| int hend = min(hstart + sizeY, height + padH); | ||
| int wend = min(wstart + sizeX, width + padW); | ||
| int poolsize = (hend - hstart) * (wend - wstart); |
There was a problem hiding this comment.
是不是hstart，wstart还要取max
hstart = max(hstart, 0); wstart = max(wstart, 0); chengduoZH reviewed Sep 18, 2017
paddle/math/Matrix.cpp Outdated
| CHECK(depth * height * width * channels == getWidth()); | ||
| CHECK(width_ == depth * width * height * channels); | ||
| CHECK(imgSizeD * imgSizeH * imgSizeW * channels == getWidth()); | ||
| CHECK(width_ == imgSizeD * imgSizeH * imgSizeW * channels); |
There was a problem hiding this comment.
CHECK(width_ == imgSizeD * imgSizeH * imgSizeW * channels);这行和上一行一个作用，删除一行吧（当初写这段代码的时候忘了删...）
There was a problem hiding this comment.
已经删除，并把对应2d实现中多余的CHECK也删了。
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fix #4136
refine related code to reduce unused computing.