add depend when doing fuse_all_optimizer on program #41178
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
Others
Describe
add depend when doing fuse_all_optimizer on program
If
fuse_all_optimizeris applied to a program, it rewrites the program with fused tensors as below,If the operators in the program are executed op-by-op, it is ok.
However, it the program is executed by an Executor that may run op parallel, the
adamandgrad_op0,grad_op1may run in any order since there are no explicit dependencies. And it is wrong.This PR adds explicit dependency in that case, by adding an empty
dependop.