Skip to content

Conversation

@chenwhql
Copy link
Contributor

@chenwhql chenwhql commented Mar 25, 2022

PR types

Function optimization

PR changes

OPs

Describe

[Phi] Move assign value op kernel into phi

assign_value_op.h有npu kernel深度依赖,暂时不能移除

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Mar 26, 2022
@PaddlePaddle PaddlePaddle unlocked this conversation Mar 26, 2022
Copy link
Contributor

@MingMingShangTian MingMingShangTian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

}

template <typename T, typename Context>
typename std::enable_if<std::is_same<T, bool>::value>::type CopyVecotorToTensor(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拼写错误?CopyVectorToTensor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

额,copy过来没注意原先就拼错了,下个PR一起fix下

@chenwhql chenwhql merged commit 324b6b7 into PaddlePaddle:develop Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants