[Phi]Move hierarchical_sigmoid kernel to phi #40553
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for your contribution! |
zyfncg reviewed Mar 17, 2022
| } | ||
| | ||
| template <typename T, typename Context> | ||
| void HierarchicalSigmoidGradKernel(const Context& ctx, |
Contributor
There was a problem hiding this comment.
selected_rows 的kernel代码和DenseTensor的看上去几乎相同，这里是否可以复用DenseTensor的kernel?
Contributor Author
There was a problem hiding this comment.
这个尝试过，但是selectrows最后计算的时候还用到了selectrows的tensor，
bit_code->MulGradWeight(pre_out_grad, w_grad, x);
这里pre_out_grad是计算得到的，w_grad是selectrow。所以要复用的话，需要再封装个辅助函数，返回这个值，最后计算。开始考虑到逻辑复杂性就先没写，这个后面我在实现下
Contributor
There was a problem hiding this comment.
如果重复代码量太多，建议后边还是逻辑再封装一下吧
zyfncg approved these changes Mar 18, 2022
YuanRisheng approved these changes Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
[Phi]Move hierarchical_sigmoid kernel to phi