Skip to content

[hybrid fix] fix sharding save offload #40477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2022
Merged

[hybrid fix] fix sharding save offload #40477

merged 1 commit into from
Mar 14, 2022

Conversation

@wangxicoding
Copy link
Contributor

@wangxicoding wangxicoding commented Mar 12, 2022

PR types

Bug fixes

PR changes

Others

Describe

Fix sharding save_persistables don't save fp16 param and offload var when use offload.
@paddle-bot-old
Copy link

paddle-bot-old bot commented Mar 12, 2022

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.
@wangxicoding wangxicoding requested a review from JZ-LIANG March 14, 2022 08:03
JZ-LIANG
JZ-LIANG approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@JZ-LIANG JZ-LIANG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@wangxicoding wangxicoding merged commit edd97f9 into PaddlePaddle:develop Mar 14, 2022
@wangxicoding wangxicoding deleted the fix_sharding_save_offload branch March 14, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@wangxicoding @JZ-LIANG